Skip to content

PageHeader: Fixes layout issues on title and sub components #4669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
broccolinisoup merged 15 commits into from
Jun 26, 2024
Merged

PageHeader: Fixes layout issues on title and sub components #4669

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c7b4c55
layout shift issue resolve
broccolinisoup Jun 12, 2024
ceb02ed
do not inherit font and line styles from parent for description and n…
broccolinisoup Jun 13, 2024
59375b4
font initial size and line hight only weight
broccolinisoup Jun 13, 2024
137f184
Merge branch 'main' into pageheader-layout-shift
broccolinisoup Jun 13, 2024
ae2430e
Merge branch 'main' into pageheader-layout-shift
broccolinisoup Jun 13, 2024
e0cba61
set font styles to sub components
broccolinisoup Jun 17, 2024
655365b
style update
broccolinisoup Jun 17, 2024
b643195
test fix
broccolinisoup Jun 17, 2024
6ae320e
Create two-hotels-attend.md
broccolinisoup Jun 17, 2024
080009a
test(vrt): update snapshots
broccolinisoup Jun 17, 2024
3b0dee5
update line height to medium
broccolinisoup Jun 17, 2024
9127877
test(vrt): update snapshots
broccolinisoup Jun 17, 2024
b199906
breadcrumb line height update
broccolinisoup Jun 18, 2024
8ffa559
Merge branch 'main' into pageheader-layout-shift
broccolinisoup Jun 25, 2024
4ce72c2
test(vrt): update snapshots
broccolinisoup Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
do not inherit font and line styles from parent for description and n… 
…avigation slot
  • Loading branch information
@broccolinisoup
broccolinisoup committed Jun 13, 2024
commit ceb02ed8ec4f3c16275920097ff337cf4aa6a8d2
7 changes: 7 additions & 0 deletions packages/react/src/PageHeader/PageHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,7 @@ const Title: React.FC<React.PropsWithChildren<TitleProps>> = ({children, sx = {}
}),
fontSize: 'inherit',
fontWeight: 'inherit',
lineHeight: 'inherit',
},
sx,
)}
Expand Down Expand Up @@ -552,6 +553,9 @@ const Description: React.FC<React.PropsWithChildren<ChildrenPropTypes>> = ({chil
alignItems: 'center',
paddingTop: '0.5rem',
gap: '0.5rem',
fontSize: 'initial',
fontWeight: 'initial',
lineHeight: 'initial',
},
sx,
)}
Expand Down Expand Up @@ -596,6 +600,9 @@ const Navigation: React.FC<React.PropsWithChildren<NavigationProps>> = ({
...getBreakpointDeclarations(hidden, 'display', value => {
return value ? 'none' : 'block'
}),
fontSize: 'initial',
fontWeight: 'initial',
lineHeight: 'initial',
},
sx,
)}
Expand Down