-
Notifications
You must be signed in to change notification settings - Fork 650
feat: added support for className to <AnchoredOverlay> #4741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for className to <AnchoredOverlay> #4741
Conversation
|
broccolinisoup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thanks for pushing this PR. There is a type error about the new className prop. Could you please make sure the new prop type is also defined?
Sure, will look at it today. |
|
Hello @Princeyadav05 👋🏻 Let me know if you need a hand with fixing the type issue! We have another PR raised for the same issue and I am trying to coordinate so that we can have both of your contributions, ideally 😊 |
Will try to close it in a couple of hours. Thanks you for your co-ordination. 😊 |
|
@broccolinisoup have made the required changes. Do let me know if anything else is required. |
…o-AnchoredOverlay-
broccolinisoup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Princeyadav05!! 🎉
### description: - the previous PR, which also included the necessary changes: primer#4741 - only the changes to Storybook were kept
…4752) * Added className prop to AnchoredOverlay component ### Description: - Added `className` prop to allow custom styling of the `AnchoredOverlay` component - This change addresses issue #4739 * Updated AnchoredOverlay documentation to include className prop ### Description: - Added `className` prop to `AnchoredOverlay.docs.json` * add changeset * Revert "add changeset" This reverts commit 4a59f6a. * Updated the code according to PR#4741 ### description: - the previous PR, which also included the necessary changes: #4741 - only the changes to Storybook were kept --------- Co-authored-by: Armagan Ersoz <[email protected]>
Closes #4739
This PR adds the ability to apply custom CSS classes to the
AnchoredOverlaycomponent's overlay.Changelog
Changed
AnchoredOverlaycomponent to pass through alloverlayPropsto the internalOverlaycomponent.Removed
Rollout strategy
This change adds new functionality without breaking existing behavior, making it suitable for a minor release.
Testing & Reviewing
To test this change:
AnchoredOverlaycomponent with a custom class:Merge checklist