-
Notifications
You must be signed in to change notification settings - Fork 632
Remove support for sx
from BaseStyles
component
#6878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 9fb35f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
… the removal of Box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes support for the sx
prop from the BaseStyles
component as part of the migration away from styled-components. The change simplifies the component by removing system props handling and the associated wrapper component.
- Remove
sx
and system props support fromBaseStyles
component - Update component implementation to use direct element rendering instead of
BoxWithFallback
- Clean up associated tests, stories, and documentation
Reviewed Changes
Copilot reviewed 5 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/react/src/BaseStyles.tsx | Remove sx and system props support, simplify component implementation |
packages/react/src/tests/BaseStyles.test.tsx | Remove test for system props functionality |
packages/react/src/BaseStyles.dev.stories.tsx | Remove stories demonstrating sx and system props usage |
e2e/components/BaseStyles.test.ts | Remove visual regression tests for sx and system props stories |
.changeset/sharp-beans-run.md | Add changeset documenting the breaking change |
Closes #6758
Current
sx
usage: 0✅ Don't need to separately update github-ui components to use @primer/styled-react
Changelog
Removed
Remove support for
sx
from theBaseStyles
component, and any associated stories, docs, and testsRollout strategy
This component currently has 0
sx
usage in dotcom, and therefore does not need the @primer/styled-react wrapper. this will be confirmed again before merging.Merge checklist