Skip to content

Conversation

@camertron
Copy link
Collaborator

@camertron camertron commented Jul 22, 2024

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

This PR introduces a number of defaults to SelectPanel::ItemLists, which fixes an issue causing selection problems. If there is a mismatch between the SelectPanel's select variant and the select variant specified for a SelectPanel::ItemList, clicking on list items appears not to check them.

I also fixed a bug that prevented the "No results" label from appearing for SelectPanels with static item lists (i.e. the local fetch strategy).

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
    - [ ] Tested in Chrome
    - [ ] Tested in Firefox
    - [ ] Tested in Safari
    - [ ] Tested in Edge

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2024

🦋 Changeset detected

Latest commit: 6982d39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@camertron camertron marked this pull request as ready for review July 23, 2024 16:46
@camertron camertron requested review from a team as code owners July 23, 2024 16:46
@camertron camertron requested review from jonrohan, kendallgassner, owenniblock and tbenning and removed request for owenniblock and tbenning July 23, 2024 16:46
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants