Ensure Enter, Down, Home, and End behave as expected when a SelectPanel's input field has focus #2966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…put field has focus
🦋 Changeset detectedLatest commit: 39a7073 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
requested review from
jonrohan and
siddharthkp
and removed request for
siddharthkp
jonrohan
approved these changes
Jul 25, 2024
camertron
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
This PR addresses feedback from the projects/memex team around pressing the Down arrow when the filter input field has focus: https://github.com/github/accessibility/discussions/6500#discussioncomment-10124428
Integration
No changes necessary in production.
Risk Assessment
What approach did you choose and why?
I made these changes in accordance with our API docs for `SelectPanel (internal-only): https://github.com/github/primer/blob/90ca31f40b92b4365a01b64325f8fdf93f80725b/apis/select-panel-api.md. In addition to fixing the behavior of the Down key, I also added behavior for the Home and End keys.
Accessibility
Merge checklist
- [ ] Added/updated documentation- [ ] Added/updated previews (Lookbook)Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.