Skip to content

FES + i18n: Load translations from a CDN #4701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stalgiag merged 5 commits into from
Jul 29, 2020
Merged

FES + i18n: Load translations from a CDN #4701

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e70c1a9
Load translation from cdn
akshay-99 Jul 20, 2020
1547268
Release translation assets to NPM for CDN access
akshay-99 Jul 20, 2020
5937bc7
Use local translation files in dev mode
akshay-99 Jul 20, 2020
65ebcad
Update i18n contributor_docs
akshay-99 Jul 26, 2020
362adf8
Fix typo
akshay-99 Jul 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update i18n contributor_docs
  • Loading branch information
@akshay-99
akshay-99 committed Jul 29, 2020
commit 65ebcadc99a9c18470e8a241854ed706301c9f07
7 changes: 6 additions & 1 deletion contributor_docs/internationalization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,12 @@ The easiest way to do this is to add your language code (like "de" for German, "

This will generate you a fresh translations file in `translations/{LANGUAGE_CODE}/`! Now you can begin populating it with your fresh translations! 🥖

You'll also need to add an entry for it in `translations/index.js`. You can follow the pattern used in that file for `en` and `es`.
You'll also need to add an entry for it in [`translations/index.js`](../translations/index.js) and [`translations/dev.js`](../translations/dev.js). You can follow the pattern used in that file for `en` and `es`.

### Testing changes
The bulk of translations are not included in the final library, but are hosted online and are automatically downloaded by p5.js when it needs them. Updates to these only happen whenever a new version of p5.js is released.

However, if you want to see your changes (or any other changes which aren't released yet), you can simply run `npm run dev` which will build p5.js configured to use the translation files present locally on your computer, instead of the ones on the internet.

### Further Reading

Expand Down