Improve clarity of specularColor() example
#5314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aims to better demonstrate the function.
|
@stalgiag bumping this PR for review. Previously updated as per requested changes. |
stalgiag
approved these changes
Feb 21, 2022
1 task
1 task
1 task
This was referenced Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current example does not do the best job of showcasing
specularColor. Since the colors of the pointlights are set to the same value as the specular color, it is not clear what the specular color adds to the scene. For example, if you comment out the lines with calls tospecularColor(), the change the omission makes is not obvious.current
current with
specularColorlines commented outThe example I have replaced it with aims to make the relationship more clear. Here is a live version. The light is given a white color, while the specular color is set to red. By clicking the mouse, you can toggle whether the specular color is set to red, or not set (and thus the default of white).
change with red specular color
change with default specular color
Change as docs:
