Fixed bug were cached colors are not cleared

[0xJonas]

Changes:

When using the setRed()/setGreen()/setBlue()/setAlpha() methods of p5.Color, cached HSL and HSB values are not cleared properly. This leads to the following bug:

const c = color(255, 0, 0);
console.log(lightness(c)) // 50
c.setRed(0);
console.log(lightness(c)); // bug: still 50

The first call to lightness() computes the HSL values and caches them, the second call retrieves the cached values even though the RGB values have changed. The fix is simple: Clear the hsba and hsla fields of p5.Color when calling setRed()/setGreen()/setBlue()/setAlpha().

PR Checklist

• npm run lint passes
• [Inline documentation] is included / updated
• [Unit tests] are included / updated

[welcome]

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

[ecridge]

Nice catch!

It might be better to test that the value returned from lightness(c) changes when you call c.setRed(100) etc (rather than looking at the caches directly), but either way this LGTM – thanks :)

[montoyamoraga]

@all-contributors please add @0xJonas for bug

[allcontributors]

@montoyamoraga

I've put up a pull request to add @0xJonas! 🎉