Skip to content

Fixes issue #5603 #5604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 25, 2022
Merged

Fixes issue #5603 #5604

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b8c5da3
fixes issue #5191 along with minor grammatical edits
reejuBhattacharya Feb 6, 2022
1c193bf
initial commit
reejuBhattacharya Feb 16, 2022
ef166a5
remove comments
reejuBhattacharya Feb 16, 2022
c029a70
Revert "fixes issue #5191 along with minor grammatical edits"
reejuBhattacharya Feb 16, 2022
52c4969
made changes as suggested
reejuBhattacharya Feb 17, 2022
9499111
minor linting changes
reejuBhattacharya Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
minor linting changes
  • Loading branch information
@reejuBhattacharya
reejuBhattacharya committed Feb 17, 2022
commit 9499111266e35e29261f90e850dfbb1f372ec639
4 changes: 2 additions & 2 deletions src/dom/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,14 +955,14 @@ p5.prototype.createRadio = function() {
// forEach loop to uncheck all radio buttons before
// setting any one as checked.
self._getOptionsArray().forEach(option => {
option.removeAttribute('checked');
option.checked = false;
option.removeAttribute('checked');
});

for (const option of self._getOptionsArray()) {
if (option.value === value) {
option.checked = true;
option.setAttribute('checked', true);
option.checked = true;
result = option;
}
}
Expand Down