Skip to content

Fixes Issue #5646 (httpGet() not showing friendly error message) #5647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reejuBhattacharya wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes Issue #5646 (httpGet() not showing friendly error message) #5647

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f64860d
initial commit
reejuBhattacharya Mar 27, 2022
741e180
remove unnecessary comments
reejuBhattacharya Mar 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove unnecessary comments
  • Loading branch information
@reejuBhattacharya
reejuBhattacharya committed Mar 27, 2022
commit 741e180627001a295cdbaa0768255dab4ecce72c
16 changes: 4 additions & 12 deletions src/io/files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,10 +823,10 @@ p5.prototype.httpGet = function() {

const args = Array.prototype.slice.call(arguments);
const path = args[0];
let datatype; // String
let data; // Object|Boolean
let callback; // Function
let errorCallback; // Function
let datatype;
let data;
let callback;
let errorCallback;

for (let i = 1; i < args.length; i++) {
const arg = args[i];
Expand All @@ -843,12 +843,6 @@ p5.prototype.httpGet = function() {
}
}

// args.splice(1, 0, 'GET');
// const argsArray = [path, 'GET', datatype];
// if (data) argsArray.push(data);
// if (callback) argsArray.push(callback);
// if (errorCallback) argsArray.push(err);

return this.httpDo(
path,
'GET',
Expand All @@ -870,8 +864,6 @@ p5.prototype.httpGet = function() {
}
}
);

// return p5.prototype.httpDo.apply(this, argsArray);
};

/**
Expand Down