Skip to content

Fix noSmooth printing message when used with a non WebGL graphics #5726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2022
Merged

Fix noSmooth printing message when used with a non WebGL graphics #5726

merged 1 commit into from
Jul 16, 2022

Conversation

limzykenneth
Copy link
Member

@limzykenneth limzykenneth commented Jul 16, 2022 •
edited by Qianqianye
Loading

Resolves #5723

Changes:

Put the setAttribute call behind a check that current renderer is WebGL.

PR Checklist

@Qianqianye Qianqianye requested review from stalgiag and removed request for stalgiag July 16, 2022 17:54
@Qianqianye Qianqianye merged commit aa15566 into processing:main Jul 16, 2022
@Qianqianye
Copy link
Contributor

Looks great. Thank you @limzykenneth ! ✨

@IkeB108
Copy link
Contributor

IkeB108 commented Jul 16, 2022

Thanks so much!

@renovate renovate bot mentioned this pull request Jul 21, 2022
Merged
1 task
@renovate renovate bot mentioned this pull request Sep 25, 2022
Open
1 task
@renovate renovate bot mentioned this pull request Nov 7, 2022
Merged
1 task
This was referenced Nov 20, 2022
Open
Merged
@limzykenneth limzykenneth deleted the fix-nosmooth-warn branch July 1, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

p5 logs a message every time noSmooth() is called on a graphics object

3 participants

@limzykenneth @Qianqianye @IkeB108