textToPoints() not handling line-breaks correctly #6163
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5474
Changes:
Since the issue was caused was related to a line-break, we have added code that identifies line-breaks in the text if it exists. So lines are split accordingly where a line-break exists. We also added code to identify tab ('\t') characters in these lines, and replaced them with 2 spaces. What this entails is that textToPoint() is now able to print new lines, in the sense of moving to a new line prior to print the next character.
Screenshots of the change:
PR Checklist
npm run lint
passes