Skip to content

Adding missing examples to the documentation. #6751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deveshidwivedi wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Adding missing examples to the documentation. #6751

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
671ccbf
endGeometry example added
deveshidwivedi Jan 16, 2024
2acda5f
frameBuffer.end example added
deveshidwivedi Jan 16, 2024
446f039
computeFaces() example added.
deveshidwivedi Jan 16, 2024
0df1999
normalize() example added.
deveshidwivedi Jan 16, 2024
f0f0e48
Merge branch 'processing:main' into p5examples
deveshidwivedi Jan 18, 2024
5e4b094
createFramebuffer example added.
deveshidwivedi Jan 18, 2024
244a61a
MediaElement disconnect example added.
deveshidwivedi Jan 19, 2024
e10b406
MediaElement connect example added.
deveshidwivedi Jan 19, 2024
8668774
Image.js pixelDensity example added.
deveshidwivedi Jan 19, 2024
b8b784b
frameBuffer.pixelDensity example added
deveshidwivedi Jan 19, 2024
51b9b9f
Merge branch 'processing:main' into p5examples
deveshidwivedi Jan 19, 2024
09ff1c1
fix linting error
deveshidwivedi Jan 19, 2024
f3e72da
fix linting errors
deveshidwivedi Jan 19, 2024
8f91ad7
fix linting errors
deveshidwivedi Jan 19, 2024
30883f0
Update 3d_primitives.js
deveshidwivedi Jan 19, 2024
8fedf61
Merge branch 'processing:main' into p5examples
deveshidwivedi Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
frameBuffer.pixelDensity example added
  • Loading branch information
@deveshidwivedi
deveshidwivedi authored Jan 19, 2024
commit b8b784b6f061187e308fef3fa3e4100a84ceeb22
26 changes: 26 additions & 0 deletions src/webgl/p5.Framebuffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,32 @@ class Framebuffer {
* @method pixelDensity
* @param {Number} [density] A scaling factor for the number of pixels per
* side of the framebuffer
* @example
* <div>
* <code>
* let pg;
*
* function setup() {
* createCanvas(150, 150);
* pixelDensity(4);
* pg = createGraphics(75, 75);
Copy link
Collaborator

@perminder-17 perminder-17 Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm uncertain about whether we should include examples in all files containing the same method, such as pixelDensity, which is present in three files. If it's advisable, we could consider adding relevant examples in each corresponding file. What are your thoughts on this matter? for the example (pixelDensity), I believe we're referring to the method created on p5.framebuffer. Could we include an example related to using framebuffer instead of createGraphics? This might provide more relevant examples. What you think?

Copy link
Contributor Author

@deveshidwivedi deveshidwivedi Jan 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for p5.Framebuffer.pixelDensity it would indeed be more relevant to add an example using framebuffer instead of createGraphics.

* pg.pixelDensity(1);
* }
*
* function draw() {
* background(220);
* fill(255, 0, 0);
* ellipse(25, 25, 40, 40);
* pg.background(255);
* pg.fill(0, 0, 255);
* pg.ellipse(50, 50, 40, 40);
* image(pg, 75, 75);
* }
* </code>
* </div>
*
* @alt
* A red and a blue ellipse on a canvas.
*/
pixelDensity(density) {
if (density) {
Expand Down