fix: text() swallows characters in CHAR wrap mode #7437

[top-mind]

Resolves #7437

Changes:

diff --git a/src/core/p5.Renderer.js b/src/core/p5.Renderer.js
index 21ce3bd64..a08966639 100644
--- a/src/core/p5.Renderer.js
+++ b/src/core/p5.Renderer.js
@@ -390,9 +390,9 @@ class Renderer extends p5.Element {
               line = `${chars[charIndex]}`;
             }
           }
+          nlines.push(line);
         }
 
-        nlines.push(line);
         let offset = 0;
         if (this._textBaseline === constants.CENTER) {
           offset = (nlines.length - 1) * p.textLeading() / 2;
@@ -423,16 +423,16 @@ class Renderer extends p5.Element {
               line = `${chars[charIndex]}`;
             }
           }
+          this._renderText(
+            p,
+            line.trim(),
+            x,
+            y - offset,
+            finalMaxHeight,
+            finalMinHeight
+          );
+          y += p.textLeading();
         }
-        this._renderText(
-          p,
-          line.trim(),
-          x,
-          y - offset,
-          finalMaxHeight,
-          finalMinHeight
-        );
-        y += p.textLeading();
       }
     } else {
     // Offset to account for vertically centering multiple lines of text - no

Screenshots of the change:

PR Check

list

• npm run lint passes
• Inline documentation is included / updated
• Unit tests are included / updated

[welcome]

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

[davepagurek]

Thanks @top-mind! As we move towards a 2.0 release in the new year, a lot of refactoring is being done in the dev-2.0 branch. @dhowe do you think it would make sense to try to do this change in dev-2.0 instead, since I believe this section of code has moved in that branch?

[dhowe]

I don't see this issue in v2.0:

function setup() {
    createCanvas(100, 100);
    textWrap(CHAR);
    text("1\n222\n3", 0, 0, 20);
}

function setup() {
    createCanvas(100, 100);
    textWrap(CHAR);
    textSize(15);
    text("1\n222\n3", 0, 0, 20);
}

[davepagurek]

ok nice! @ksen0 @limzykenneth do you think we'll be doing another 1.x release before 2.0? if so, it could make sense to merge this to get the fix in for users ahead of 2.0.