Skip to content

Conversation

@southwest-git
Copy link

Resolves #7259

Changes:

Some shapes located outside of the canvas and the current check in _gridMap only applies to positive locX and locY but not negative values. The fix is to check for negative values and hence avoiding a negative indexing to an array which causes the issue.

Screenshots of the change:

PR Checklist

Fix for issue 7259 to check for negative locX and locY in gridOutput.js
@welcome
Copy link

welcome bot commented Mar 11, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

@ksen0
Copy link
Member

ksen0 commented Mar 26, 2025

Hi @himanshuukholiya I saw you were active on the related issue here #7259, can you check if this is still relevant? The issue seems to be marked as resolved. Thanks!

@himanshuukholiya
Copy link
Contributor

hello @ksen0 yes, the issue has been resolved. #7626 ressolves this issue

@ksen0
Copy link
Member

ksen0 commented Mar 28, 2025

Thanks @himanshuukholiya .
@southwest-git , thank you for your effort, but in the future please check first if the work is already being done by someone else! I'll close this one.

@ksen0 ksen0 closed this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mostly offscreen primitive shapes throws error

3 participants