Skip to content

[dev-2.0] fix bug in textAscent/Descent #7657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davepagurek merged 1 commit into from
Mar 25, 2025
Merged

[dev-2.0] fix bug in textAscent/Descent #7657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix bugs in textAscent/Descent
  • Loading branch information
@dhowe
dhowe committed Mar 22, 2025
commit a000a7c8ea9c4e072663cecf293fddb1ef8f76af
4 changes: 2 additions & 2 deletions src/type/textCore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ function textCore(p5, fn) {
*/
Renderer.prototype.textAscent = function (txt = '') {
if (!txt.length) return this.fontAscent();
return this.textDrawingContext().measureText(txt)[prop];
return this.textDrawingContext().measureText(txt).actualBoundingBoxAscent;
};

/**
Expand All @@ -334,7 +334,7 @@ function textCore(p5, fn) {
*/
Renderer.prototype.textDescent = function (txt = '') {
if (!txt.length) return this.fontDescent();
return this.textDrawingContext().measureText(txt)[prop];
return this.textDrawingContext().measureText(txt).actualBoundingBoxDescent;
};

/**
Expand Down