Skip to content

Fixed camera tilt up vector #7702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Forchapeatl wants to merge 10 commits into
base: dev-2.0
Choose a base branch
from
Draft

Fixed camera tilt up vector #7702

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0dd073b
Fixed camera tilt up vector
Forchapeatl Apr 5, 2025
b3b2b50
Removed P5 Vector
Forchapeatl Apr 6, 2025
fb8672c
Fixed syntax error
Forchapeatl Apr 6, 2025
517946d
Fixed failed tests
Forchapeatl Apr 6, 2025
80cf66e
Added test on Rotated Up Vector
Forchapeatl Apr 6, 2025
9199cd9
Remove P5 Vector
Forchapeatl Apr 6, 2025
ff0c805
Update p5.Camera.js
Forchapeatl Apr 6, 2025
f7c9c8c
Update p5.Camera.js
Forchapeatl Apr 6, 2025
bd240a7
Update p5.Camera.js tests
Forchapeatl Apr 6, 2025
91d8260
reverted changes
Forchapeatl Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed syntax error
  • Loading branch information
@Forchapeatl
Forchapeatl authored Apr 6, 2025
commit fb8672c4559fa583dcc1467aa6ebd01ba2067446
7 changes: 3 additions & 4 deletions src/webgl/p5.Camera.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1620,14 +1620,13 @@

// Rotate the up vector to keep the correct camera orientation
/* eslint-disable max-len */

const rotatedUpX = this.upX * rotation.mat4[0] + this.upY * rotation.mat4[4] + this.upZ * rotation.mat4[8],
const rotatedUpY = this.upX * rotation.mat4[1] + this.upY * rotation.mat4[5] + this.upZ * rotation.mat4[9],
const rotatedUpZ = this.upX * rotation.mat4[2] + this.upY * rotation.mat4[6] + this.upZ * rotation.mat4[10]
const rotatedUpX = this.upX * rotation.mat4[0] + this.upY * rotation.mat4[4] + this.upZ * rotation.mat4[8];
const rotatedUpY = this.upX * rotation.mat4[1] + this.upY * rotation.mat4[5] + this.upZ * rotation.mat4[9];
const rotatedUpZ = this.upX * rotation.mat4[2] + this.upY * rotation.mat4[6] + this.upZ * rotation.mat4[10];
/* eslint-enable max-len */

//Normalize the up vector
const normalizedUpX = rotatedUpX / upLength;

Check failure on line 1629 in src/webgl/p5.Camera.js

View workflow job for this annotation

GitHub Actions / test

test/unit/webgl/p5.Camera.js > p5.Camera > Rotation > Pan() with positive parameter sets correct matrix w/o changing eyeXYZ or upXYZ 

ReferenceError: upLength is not defined
 ❯ Camera._rotateView src/webgl/p5.Camera.js:1629:40
 ❯ Camera.pan src/webgl/p5.Camera.js:1789:10
 ❯ test/unit/webgl/p5.Camera.js:93:13

Check failure on line 1629 in src/webgl/p5.Camera.js

View workflow job for this annotation

GitHub Actions / test

test/unit/webgl/p5.Camera.js > p5.Camera > Rotation > Pan() with negative parameter sets correct matrix w/o changing eyeXYZ or upXYZ 

ReferenceError: upLength is not defined
 ❯ Camera._rotateView src/webgl/p5.Camera.js:1629:40
 ❯ Camera.pan src/webgl/p5.Camera.js:1789:10
 ❯ test/unit/webgl/p5.Camera.js:117:13

Check failure on line 1629 in src/webgl/p5.Camera.js

View workflow job for this annotation

GitHub Actions / test

test/unit/webgl/p5.Camera.js > p5.Camera > Rotation > Pan(0) sets correct matrix w/o changing eyeXYZ or upXYZ 

ReferenceError: upLength is not defined
 ❯ Camera._rotateView src/webgl/p5.Camera.js:1629:40
 ❯ Camera.pan src/webgl/p5.Camera.js:1789:10
 ❯ test/unit/webgl/p5.Camera.js:138:13

Check failure on line 1629 in src/webgl/p5.Camera.js

View workflow job for this annotation

GitHub Actions / test

test/unit/webgl/p5.Camera.js > p5.Camera > Rotation > Tilt() with positive parameter sets correct Matrix w/o changing eyeXYZ 

ReferenceError: upLength is not defined
 ❯ Camera._rotateView src/webgl/p5.Camera.js:1629:40
 ❯ Camera.tilt src/webgl/p5.Camera.js:1854:10
 ❯ test/unit/webgl/p5.Camera.js:162:13

Check failure on line 1629 in src/webgl/p5.Camera.js

View workflow job for this annotation

GitHub Actions / test

test/unit/webgl/p5.Camera.js > p5.Camera > Rotation > Tilt() with negative parameter sets correct matrix w/o changing eyeXYZ 

ReferenceError: upLength is not defined
 ❯ Camera._rotateView src/webgl/p5.Camera.js:1629:40
 ❯ Camera.tilt src/webgl/p5.Camera.js:1854:10
 ❯ test/unit/webgl/p5.Camera.js:182:13

Check failure on line 1629 in src/webgl/p5.Camera.js

View workflow job for this annotation

GitHub Actions / test

test/unit/webgl/p5.Camera.js > p5.Camera > Rotation > Tilt(0) sets correct matrix w/o changing eyeXYZ 

ReferenceError: upLength is not defined
 ❯ Camera._rotateView src/webgl/p5.Camera.js:1629:40
 ❯ Camera.tilt src/webgl/p5.Camera.js:1854:10
 ❯ test/unit/webgl/p5.Camera.js:200:13

Check failure on line 1629 in src/webgl/p5.Camera.js

View workflow job for this annotation

GitHub Actions / test

test/unit/webgl/p5.Camera.js > p5.Camera > Rotation with angleMode(DEGREES) > Pan() with positive parameter sets correct matrix w/o changing eyeXYZ or upXYZ 

ReferenceError: upLength is not defined
 ❯ Camera._rotateView src/webgl/p5.Camera.js:1629:40
 ❯ Camera.pan src/webgl/p5.Camera.js:1789:10
 ❯ test/unit/webgl/p5.Camera.js:313:13

Check failure on line 1629 in src/webgl/p5.Camera.js

View workflow job for this annotation

GitHub Actions / test

test/unit/webgl/p5.Camera.js > p5.Camera > Rotation with angleMode(DEGREES) > Tilt() with positive parameter sets correct Matrix w/o changing eyeXYZ 

ReferenceError: upLength is not defined
 ❯ Camera._rotateView src/webgl/p5.Camera.js:1629:40
 ❯ Camera.tilt src/webgl/p5.Camera.js:1854:10
 ❯ test/unit/webgl/p5.Camera.js:336:13

Check failure on line 1629 in src/webgl/p5.Camera.js

View workflow job for this annotation

GitHub Actions / test

test/unit/webgl/p5.Camera.js > p5.Camera > slerp() > Behavior of slerp() for camera moved by pan() 

ReferenceError: upLength is not defined
 ❯ Camera._rotateView src/webgl/p5.Camera.js:1629:40
 ❯ Camera.pan src/webgl/p5.Camera.js:1789:10
 ❯ test/unit/webgl/p5.Camera.js:868:12

Check failure on line 1629 in src/webgl/p5.Camera.js

View workflow job for this annotation

GitHub Actions / test

test/unit/webgl/p5.Camera.js > p5.Camera > slerp() > Behavior of slerp() for camera moved by tilt() 

ReferenceError: upLength is not defined
 ❯ Camera._rotateView src/webgl/p5.Camera.js:1629:40
 ❯ Camera.tilt src/webgl/p5.Camera.js:1854:10
 ❯ test/unit/webgl/p5.Camera.js:890:12
const normalizedUpY = rotatedUpY / upLength;
const normalizedUpZ = rotatedUpZ / upLength;

Expand Down