Skip to content

Updating all the broken refrence examples. #7739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksen0 merged 30 commits into from
May 13, 2025
+125 −88
Merged

Updating all the broken refrence examples. #7739

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
81ff09d
updating computeFaces
perminder-17 Apr 15, 2025
77a1492
fixed vertexNormals
perminder-17 Apr 16, 2025
302e25b
vertices fixing
perminder-17 Apr 16, 2025
ade54ac
fixing
perminder-17 Apr 16, 2025
9df7595
fixing setAlpha
perminder-17 Apr 16, 2025
28cf83f
fixing-setGreen
perminder-17 Apr 16, 2025
5d2aad1
updating fontAscent
perminder-17 Apr 16, 2025
9e7445f
fixing @method pixels
perminder-17 Apr 16, 2025
12a6a17
fixing-getCurrentFrame()
perminder-17 Apr 16, 2025
8f017b0
fixing numFrames
perminder-17 Apr 16, 2025
eaedc0a
fixing setFrame()
perminder-17 Apr 16, 2025
2abbd76
fixing describe()
perminder-17 Apr 16, 2025
7b5d67c
fixing gridOutputs
perminder-17 Apr 16, 2025
c3851b3
fixing text-output
perminder-17 Apr 16, 2025
dac7ff2
fixing all p5.Camera text orientation
perminder-17 Apr 16, 2025
d19fefc
fixing setAttributes()
perminder-17 Apr 18, 2025
e4acb5f
fixing httpDo
perminder-17 Apr 18, 2025
9039796
fixing httpPost
perminder-17 Apr 18, 2025
63af24e
fixing print()
perminder-17 Apr 18, 2025
24763af
fixing getNum()
perminder-17 Apr 19, 2025
301d42f
Fixing rotationX(), rotationY() and rotationZ()
perminder-17 Apr 19, 2025
dd6a988
updating checkBox()
perminder-17 Apr 19, 2025
58e8746
createFileInput() orientation
perminder-17 Apr 19, 2025
25b164e
minor fixes
perminder-17 Apr 19, 2025
bf86b77
createElement fixes
perminder-17 Apr 19, 2025
289c176
fixing wording of setup() by removing preload
perminder-17 Apr 19, 2025
36b0bb0
fixing broken url
perminder-17 Apr 23, 2025
608d2fa
adding more context to docs
perminder-17 Apr 23, 2025
68dd3ae
reverting back to old p5.Geometry
perminder-17 Apr 23, 2025
cefb10b
Merge branch 'dev-2.0' into patch-9
perminder-17 Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing text-output
  • Loading branch information
@perminder-17
perminder-17 authored Apr 16, 2025
commit c3851b3dc7801c87df7ad0837c12a21b495ea22f
10 changes: 10 additions & 0 deletions src/accessibility/outputs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ function outputs(p5, fn){
*
* <div>
* <code>
*
Copy link
Collaborator Author

@perminder-17 perminder-17 Apr 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ksen0 , are these functions still broken on my branch as well i.e. After this PR?. I think I tried fixing textOutput() and gridOutput here.

Copy link
Member

@ksen0 ksen0 Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect there's bigger problems here because they're broken on 1.x and 2.0. I'll make a separate 1.x/2.0 issue tomorrow about it, please feel free to ignore for this PR. Thank you!

Copy link
Collaborator Author

@perminder-17 perminder-17 Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect there's bigger problems here because they're broken on 1.x and 2.0. I'll make a separate 1.x/2.0 issue tomorrow about it, please feel free to ignore for this PR. Thank you!

Hmm, So sorry for the oversight, I think the sketch works correctly but it didn't shows up correctly in the website. I'll have a look today late night or tomorrow morning to figure out what's going on. Thanks for the patience @ksen0 :)

* function setup(){
* createCanvas(100, 100);
* }
*
* function draw() {
* // Add the text description.
* textOutput();
Expand All @@ -101,6 +106,11 @@ function outputs(p5, fn){
*
* <div>
* <code>
*
* function setup(){
* createCanvas(100, 100);
* }
*
* function draw() {
* // Add the text description and
* // display it for debugging.
Expand Down