Fixed Error in FES prevents message from being shown, Prevented 'window' properties from being overwritten

[HughJacks]

Resolves #7678

Changes:

Added a list of protected properties in main.js to prevent p5 from overriding certain window properties:

Added a check for hasOwnProperty in fes_core.js to prevent inherited properties like constructor from causing errors:

Changed core/main.js from:

      // Attach its properties to the window
      for (const p in this) {
        if (this.hasOwnProperty(p)) {
          if(p[0] === '_') continue;
          bindGlobal(p);
        }
      }

to:

      const protectedProperties = ['constructor', 'length'];
      // Attach its properties to the window
      for (const p in this) {
        if (this.hasOwnProperty(p)) {
          if(p[0] === '_' || protectedProperties.includes(p)) continue;
          bindGlobal(p);
        }
      }

Changed core/friendly_errors/fes_core.js from:

        if (
          fxns.[lowercase] &&
          !context[fxns[lowercase]] &&
          typeof context[prop] === 'function'
        ) {

to:

        if (
          fxns.hasOwnProperty(lowercase) &&
          !context[fxns[lowercase]] &&
          typeof context[prop] === 'function'
        ) {

Screenshots of the change:

PR Checklist

• npm run lint passes
• Inline reference is included / updated
• Unit tests are included / updated

[welcome]

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

[davepagurek]

Thanks for the fix, looks good!

[davepagurek]

@all-contributors please add @HughJacks for code

[allcontributors]

@davepagurek

I've put up a pull request to add @HughJacks! 🎉