Include use of relevant maxes in hue(), saturation(), brightness() and lightness()
#8062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksen0
approved these changes
Sep 1, 2025
src/color/creating_reading.js
Outdated
| // p5._validateParameters('saturation', arguments); | ||
| return this.color(c)._getSaturation(); | ||
| const colorMode = ( | ||
| this._renderer.states.colorMode === HSB || |
Member
There was a problem hiding this comment.
Minor/optional: isn't this the same as (this._renderer.states.colorMode === HSB) ? HSB : HSL? that seems a little more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7998
Changes:
The utility functions didn't take into account the current maxes of the relevant color modes, this implements it. One particular caveat is that
hue()applies toHSB,HSLbut alsoLCHandOKLCHwhich also have hue values. This may or may not be desired but for consistency sake they are included.PR Checklist
npm run lintpasses