Skip to content

account for all covered resources when a node is cordoned #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgrove-oss merged 3 commits into from
Aug 28, 2024
Merged

account for all covered resources when a node is cordoned #239

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
844c521
account for all covered resources when a node is cordoned
dgrove-oss Aug 27, 2024
ceb0ea8
quietly handling conflict errors by requeuing
dgrove-oss Aug 27, 2024
0f3bf73
fix typo
dgrove-oss Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix typo
  • Loading branch information
@dgrove-oss
dgrove-oss committed Aug 27, 2024
commit 0f3bf73824c72a7906c874c77537e262dfc92ef7
2 changes: 1 addition & 1 deletion internal/controller/appwrapper/node_health_monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func (r *NodeHealthMonitor) Reconcile(ctx context.Context, req ctrl.Request) (ct
if node.Spec.Unschedulable {
// flag all non-pod resources covered by cq if the node is cordoned
for _, resourceName := range cq.Spec.ResourceGroups[0].Flavors[0].Resources {
if string(resourceName.Name) != "pod" {
if string(resourceName.Name) != "pods" {
flaggedQuantities[string(resourceName.Name)] = node.Status.Capacity.Name(resourceName.Name, resource.DecimalSI)
}
}
Expand Down