Skip to content

Upgrade from AppWrapper v1beta1 to v1beta2 #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 26 commits into from
Closed

Upgrade from AppWrapper v1beta1 to v1beta2 #491

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
a7a9bca
Upgrade to AppWrapper v1beta2
dgrove-oss Mar 19, 2024
635119b
Disable operator upgrade test for MCAD to Kueue transition
dgrove-oss Mar 25, 2024
5e3595f
update for review changes in codeflare-common
dgrove-oss Mar 28, 2024
c3fa25d
review comments
dgrove-oss Mar 28, 2024
5d907b5
pick up codeflare-common@mcadv1b2 changes
dgrove-oss Mar 28, 2024
04b9b1f
port to AppWrapper controller using cert-controller
dgrove-oss Mar 28, 2024
c8ead36
Kueue-enable e2e test cases
dgrove-oss Mar 29, 2024
f291e02
RayCluster test with AppWrappers
dgrove-oss Mar 29, 2024
43c8bc9
collect Kueue logs in e2e test
dgrove-oss Mar 30, 2024
f3147a6
update to appwrapper 0.7.2
dgrove-oss Apr 2, 2024
d6c87e9
validate AppWrapper config after merging delta from config map
dgrove-oss Apr 2, 2024
39c34d8
fix errors introduced in rebase
dgrove-oss Apr 3, 2024
034992d
generate AppWrapper RBAC's from kubebuilder comments
dgrove-oss Apr 3, 2024
828d0b1
appwrapper 0.7.2
dgrove-oss Apr 3, 2024
ef0665b
AppWrapper release is managed externally
dgrove-oss Apr 3, 2024
dca8dcb
tweaks
dgrove-oss Apr 3, 2024
b88ca94
allow appwrapper controller to be disabled in config
dgrove-oss Apr 4, 2024
58dcfd0
copy edit README.md
dgrove-oss Apr 4, 2024
d29c5fe
Fix type in main.go
dgrove-oss Apr 4, 2024
cbfd580
get codeflare-common from main
dgrove-oss Apr 4, 2024
b5aa4aa
review comments
dgrove-oss Apr 4, 2024
7187933
restore olm upgrade test; this test is expected to fail
dgrove-oss Apr 4, 2024
ca6b5ec
deploy Kueue in olm_tests
dgrove-oss Apr 4, 2024
2035794
review comment: keep cert config private
dgrove-oss Apr 4, 2024
e12fa53
skip AppWrapper tests when AppWrapper controller not enabled
dgrove-oss Apr 4, 2024
318f601
fix typo
dgrove-oss Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
validate AppWrapper config after merging delta from config map
  • Loading branch information
@dgrove-oss
dgrove-oss committed Apr 4, 2024
commit d6c87e9a59c2c6f259eef87169c040b2f21a02a6
1 change: 1 addition & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ func main() {
exitOnError(err, "unable to create Kubernetes client")

exitOnError(loadIntoOrCreate(ctx, kubeClient, namespaceOrDie(), configMapName, cfg), "unable to initialise configuration")
exitOnError(awconfig.ValidateConfig(cfg.AppWrapper), "invalid AppWrapper configuration")

kubeConfig.Burst = int(ptr.Deref(cfg.ClientConnection.Burst, int32(rest.DefaultBurst)))
kubeConfig.QPS = ptr.Deref(cfg.ClientConnection.QPS, rest.DefaultQPS)
Expand Down