Template and allowconn discovery #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritbl
referenced
this pull request
in heniek/postgres_exporter
Mar 19, 2023
…ercona#297) * Discover only databases that are not templates and allow connections * Update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using the option
auto-discover-databases, templates and databases that does not allow connections are returned in the result leading to errors when the exporter try to connect to them.This PR aims to get ride of them by adding a filter in the request used by the option.
The fields
datallowconnanddatistemplateare presented in the PG version supporter by the exporter so it do not include breaking changes