expfmt: Add support for float histograms and gauge histograms #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: beorn7 <[email protected]>
krajorama
reviewed
Oct 1, 2025
| for _, b := range metric.Histogram.Bucket { | ||
| if b.GetCumulativeCountFloat() > 0 { | ||
| return written, fmt.Errorf( | ||
| "float histogram %s %s not supported in OpenMetrics", |
There was a problem hiding this comment.
Let's be a bit more generic to be consistent with other errors and avoid having to say OpenMetrics version as well.
Suggested change
| "float histogram %s %s not supported in OpenMetrics", | |
| "unexpected float histogram bucket count in metric %s %s", |
There was a problem hiding this comment.
Not sure if that nails it. The float histogram is not necessarily unexpected. It's fine in the data model, just that OM v1 cannot represent it.
We could say "current format does not support float histogram bucket count in metric %s %s" or maybe "OpenMetrics v1.0 does not support float histogram bucket count in metric %s %s". WDYT?
| } | ||
| if metric.Histogram.GetSampleCountFloat() > 0 { | ||
| return written, fmt.Errorf( | ||
| "float histogram %s %s not supported in OpenMetrics", |
There was a problem hiding this comment.
Let's be a bit more generic to be consistent with other errors and avoid having to say OpenMetrics version as well.
Suggested change
| "float histogram %s %s not supported in OpenMetrics", | |
| "unexpected float histogram count in metric %s %s", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #430.