Skip to content

feat: node exporter mixin large update #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
v-zhuravlev wants to merge 15 commits into from
Closed

feat: node exporter mixin large update #2665

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b190fcd
Add some lint exclusions.
rgeyer Oct 27, 2022
a6cc3b8
Add multi-cluster dashboard lint exclusions
rgeyer Oct 27, 2022
2059552
Update mixin for linux-integration (#18)
v-zhuravlev Apr 14, 2023
fe0d3e0
Remove forced uid regeneration (#20)
v-zhuravlev Apr 14, 2023
dc6db9c
Remove + { uid: std.md5(name) } from dashboards.jsonnet as well
v-zhuravlev Apr 14, 2023
10495ef
Split alerts into two groups (#21)
v-zhuravlev Apr 19, 2023
3d79ef1
fix: fix typos (#22)
v-zhuravlev Apr 24, 2023
38b6ad6
Add datasource selector to data links
Dasomeone Jun 20, 2023
ed637a2
Fix description in node usage dashboard
Dasomeone Jul 7, 2023
203d5cd
Format jsonnet
v-zhuravlev Jul 15, 2023
720a114
Revert alerts pending durtions as agreed here https://github.com/prom…
v-zhuravlev Jun 29, 2023
836773a
Add node-observ-lib (#25)
v-zhuravlev Nov 14, 2023
4a48f6b
Add missing metrics (#27)
v-zhuravlev Nov 14, 2023
94e744e
Add Macos observability lib (#28)
v-zhuravlev Nov 28, 2023
3eb9759
Fix memory queries typos
v-zhuravlev Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add datasource selector to data links 
This fixes an issue with selecting a node, given a specific datasource, and the link not using said datasource thus showing no data

Signed-off-by: Emily Ahlstrand Rager <emily.rager@grafana.com>
  • Loading branch information
@Dasomeone @v-zhuravlev
Dasomeone authored and v-zhuravlev committed Jul 15, 2023
commit 38b6ad697085cc8086bf2c14c88aa2f9c7e6de00
4 changes: 2 additions & 2 deletions docs/node-mixin/lib/common.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,12 @@ local nodeTimeseries = nodePanels.timeseries;
// used in fleet table
instanceDataLinkForTable:: {
title: 'Drill down to instance ${__data.fields.%s}' % std.split(config.instanceLabels, ',')[0],
url: 'd/' + config.grafanaDashboardIDs['nodes.json'] + '?' + labelsToURLvars(std.split(config.instanceLabels, ','), prefix='__data.fields.') + '&${__url_time_range}',
url: 'd/' + config.grafanaDashboardIDs['nodes.json'] + '?' + labelsToURLvars(std.split(config.instanceLabels, ','), prefix='__data.fields.') + '&${__url_time_range}&var-datasource=${datasource}',
},
// used in ts panels
instanceDataLink:: {
title: 'Drill down to instance ${__field.labels.%s}' % std.split(config.instanceLabels, ',')[0],
url: 'd/' + config.grafanaDashboardIDs['nodes.json'] + '?' + labelsToURLvars(std.split(config.instanceLabels, ','), prefix='__field.labels.') + '&${__url_time_range}',
url: 'd/' + config.grafanaDashboardIDs['nodes.json'] + '?' + labelsToURLvars(std.split(config.instanceLabels, ','), prefix='__field.labels.') + '&${__url_time_range}&var-datasource=${datasource}',
},
},
// return common queries that could be used in multiple dashboards
Expand Down