-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Refactor node-mixin as node-observ-lib #2861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor node-mixin as node-observ-lib #2861
Conversation
|
Just a little question : why don't you render dashboards with .json suffix? |
Nothing specific, It was a little bit more convenient to reference dashboards by key ( |
|
If this is intended to replace the |
150c28c to
c75a766
Compare
|
|
Just let me know, if what do you think I should do to merge this :) |
|
@SuperQ ,Hi, sorry for bumping, is there anything blocking to move this forward? thanks |
|
Can it produce the same dashboards as the old mixin? Then we could remove the old one. If not, I dont know. We certainly dont want to support both.. |
|
The only difference is USE dashboards, there are not present in new set: USE dashboards (node-rsrc-use.json, node-cluster-rsrc-use.json,node-multicluster-rsrc-use.json) |
|
@v-zhuravlev Could you add the USE dashboards as well? Then I'm open to replace the old mixins with this. |
Sure, will add them shortly |
|
* Add node-observ-lib * Remove trends support (not in 10.0 schema) * Make filteringSelector for logs dashboard configurable * Temp change dependency (until PR is merged for commonlib) * Refactor config * Update jsonnetfile.json * Update README * Add separate loki example * Add sep file example Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: prombot <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Steve Wills <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Johannes Ziemke <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
We already support reading from multiple directories though only using globs. Now we can specify them outright. Example use case is exporting both static info on a RO FS generated during image building and traditional uses of textfiles (e.g. for R/W service metrics files) without scripting a file copy. * keep flag name for compatibility * clarify flag help text * add test case (replicating the glob one) Signed-off-by: eduarrrd <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Avoid Linux-specific code scattered in two places by moving it to the already-existing zfs_linux.go. Signed-off-by: Daniel Swarbrick <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Daniel Swarbrick <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Code does not modify zfsPoolStatesName slice, so make it an array. Signed-off-by: Daniel Swarbrick <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Ensure identical factory function name across arch-specific files so that the common init() function in zfs.go works. Signed-off-by: Daniel Swarbrick <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Also add build-tags to ensure it is ignored on non-relevant archs. Signed-off-by: Daniel Swarbrick <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Drop superfluous and overly pedantic typecasting for values that fit within 32 bits or where type comparison is already hinted. Signed-off-by: Daniel Swarbrick <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Avoid panic for accessing slice out of range in hwmon. Fixes: prometheus#3108 Signed-off-by: Ben Kochie <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.59.1 to 0.60.0. - [Release notes](https://github.com/prometheus/common/releases) - [Changelog](https://github.com/prometheus/common/blob/main/RELEASE.md) - [Commits](prometheus/common@v0.59.1...v0.60.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
…theus#3140) Bumps [github.com/mdlayher/wifi](https://github.com/mdlayher/wifi) from 0.2.0 to 0.3.0. - [Release notes](https://github.com/mdlayher/wifi/releases) - [Commits](mdlayher/wifi@v0.2.0...v0.3.0) --- updated-dependencies: - dependency-name: github.com/mdlayher/wifi dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: prombot <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: prombot <[email protected]> Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
8327300 to
6f48c3c
Compare
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
|
@discordianfish, hi! Any chance to check it? thanks! |





Similar to windows-observ-lib, node-observ-lib is created, using many panels from commonlib:. It also refactors everything from node-mixin by using grafonnet (v10 schema).
Node observability lib would allow:
UidandfilteringSelectorare used to avoid conflicts).To learn more about suggested mixin packaging format (observ-lib) you can check dataless example here.
What is recreated/moved from old node-mixin:
Added/Updated: