Skip to content

Add node_filesystem_mount_info metric #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SuperQ merged 4 commits into from
Jul 14, 2024
Merged

Add node_filesystem_mount_info metric #2970

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91628de
Add node_filesystem_mount_info metric
migeyel Mar 21, 2024
cf4544a
Merge branch 'prometheus:master' into master
migeyel Mar 22, 2024
2e74ac7
Expand mountinfo test fixtures
migeyel Mar 28, 2024
f28efa4
Fix linter errors
migeyel Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix linter errors 
Signed-off-by: Miguel Oliveira <[email protected]>
  • Loading branch information
@migeyel
migeyel committed Mar 28, 2024
commit f28efa4107da0597dfcd68aa4beb35015ceb97d0
5 changes: 3 additions & 2 deletions collector/filesystem_linux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ func TestMountPointDetails(t *testing.T) {
"/run/user/1000": "",
"/run/user/1000/gvfs": "",
"/var/lib/kubelet/plugins/kubernetes.io/vsphere-volume/mounts/[vsanDatastore] bafb9e5a-8856-7e6c-699c-801844e77a4a/kubernetes-dynamic-pvc-3eba5bba-48a3-11e8-89ab-005056b92113.vmdk": "",
"/var/lib/kubelet/plugins/kubernetes.io/vsphere-volume/mounts/[vsanDatastore] bafb9e5a-8856-7e6c-699c-801844e77a4a/kubernetes-dynamic-pvc-3eba5bba-48a3-11e8-89ab-005056b92113.vmdk": ""}
"/var/lib/kubelet/plugins/kubernetes.io/vsphere-volume/mounts/[vsanDatastore] bafb9e5a-8856-7e6c-699c-801844e77a4a/kubernetes-dynamic-pvc-3eba5bba-48a3-11e8-89ab-005056b92113.vmdk": "",
}

filesystems, err := mountPointDetails(log.NewNopLogger())
if err != nil {
Expand All @@ -94,7 +95,7 @@ func TestMountPointDetails(t *testing.T) {
foundSet[fs.mountPoint] = true
}

for mountPoint, _ := range expected {
for mountPoint := range expected {
if _, ok := foundSet[mountPoint]; !ok {
t.Errorf("Expected %s, got nothing", mountPoint)
}
Expand Down