Skip to content

Conversation

@rexagod
Copy link
Contributor

@rexagod rexagod commented Jun 21, 2024

Needed-for: #3032


v0.15.1 introduced some breaking changes. This patch addresses those.

@rexagod rexagod force-pushed the sync-procfs-0151 branch 3 times, most recently from 4bd9881 to b1f7005 Compare June 21, 2024 22:34

package utils

func SafeDereference[T any](s ...*T) []T {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@SuperQ
Copy link
Member

SuperQ commented Jul 2, 2024

Sorry, needs a rebase to sync up go.mod.

@rexagod rexagod force-pushed the sync-procfs-0151 branch from b1f7005 to 605c37d Compare July 2, 2024 09:38
Needed-for: prometheus#3032

Signed-off-by: Pranshu Srivastava <[email protected]>
@rexagod rexagod force-pushed the sync-procfs-0151 branch from 605c37d to 5676509 Compare July 2, 2024 09:46
Copy link
Member

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SuperQ SuperQ merged commit c0c1a8c into prometheus:master Jul 10, 2024
v-zhuravlev pushed a commit to grafana/node_exporter that referenced this pull request Nov 1, 2024
Needed-for: prometheus#3032

Signed-off-by: Pranshu Srivastava <[email protected]>
Signed-off-by: Vitaly Zhuravlev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants