Skip to content

add ReadOnlyEventStore interface - #251

Merged
codeliner merged 1 commit into
developfrom
readonlyeventstore
Jan 25, 2017
Merged

add ReadOnlyEventStore interface#251
codeliner merged 1 commit into
developfrom
readonlyeventstore

Conversation

@prolic

@prolic prolic commented Jan 25, 2017

Copy link
Copy Markdown
Member

resolves: #250

@prolic
prolic force-pushed the readonlyeventstore branch from 40418c7 to 2c10713 Compare January 25, 2017 10:31
@coveralls

coveralls commented Jan 25, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 2c10713 on readonlyeventstore into de40505 on develop.

@codeliner

codeliner commented Jan 25, 2017

Copy link
Copy Markdown
Member

easy pick ;)

@codeliner
codeliner merged commit 2c0139e into develop Jan 25, 2017
@codeliner
codeliner deleted the readonlyeventstore branch January 25, 2017 18:53
@codeliner

codeliner commented Jan 25, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

@prolic when you write:

Closes #250

then the linked issue gets closed automatically

@prolic

prolic commented Jan 25, 2017

Copy link
Copy Markdown
Member Author

Ah good to know, thx

@codeliner

codeliner commented Jan 25, 2017

Copy link
Copy Markdown
Member

the cool thing is, that github adds a note to the linked issue that it was closed by ...

@codeliner

codeliner commented Jan 25, 2017

Copy link
Copy Markdown
Member

hehe resolves also work: https://help.github.com/articles/closing-issues-via-commit-messages/
but without double point ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@codeliner codeliner

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prolic @coveralls @codeliner