-
Notifications
You must be signed in to change notification settings - Fork 16k
Provide a Ruby extension. #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [submodule "upb"] | ||
| path = upb | ||
| url = https://github.com/haberman/upb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| This directory contains the Ruby extension that implements Protocol Buffers | ||
| functionality in Ruby. | ||
|
|
||
| The Ruby extension makes use of generated Ruby code that defines message and | ||
| enum types in a Ruby DSL. You may write definitions in this DSL directly, but | ||
| we recommend using protoc's Ruby generation support with .proto files. The | ||
| build process in this directory only installs the extension; you need to | ||
| install protoc as well to have Ruby code generation functionality. | ||
|
|
||
| Installation | ||
| ------------ | ||
|
|
||
| To build this Ruby extension, you will need: | ||
|
|
||
| * Rake | ||
| * Bundler | ||
| * Ruby development headers | ||
| * a C compiler | ||
| * the upb submodule | ||
|
|
||
| First, ensure that upb/ is checked out: | ||
|
|
||
| $ cd .. # top level protobuf directory | ||
| $ git submodule init | ||
| $ git submodule update | ||
|
|
||
| Then install the required Ruby gems: | ||
|
|
||
| $ sudo gem install bundler rake rake-compiler rspec rubygems-tasks | ||
|
|
||
| Then build the Gem: | ||
|
|
||
| $ rake gem | ||
| $ gem install pkg/protobuf-$VERSION.gem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| require "rake/extensiontask" | ||
| require "rake/testtask" | ||
|
|
||
| spec = Gem::Specification.new do |s| | ||
| s.name = "protobuf" | ||
| s.version = "2.6.2" | ||
| s.licenses = ["BSD"] | ||
| s.summary = "Protocol Buffers" | ||
| s.description = "Protocol Buffers are Google's data interchange format." | ||
| s.authors = ["Protobuf Authors"] | ||
| s.email = "[email protected]" | ||
|
|
||
| s.files = ["lib/protobuf_c.so", "lib/protobuf.rb"] | ||
| end | ||
|
|
||
| Rake::ExtensionTask.new("protobuf_c", spec) do |ext| | ||
| ext.lib_dir = "lib" | ||
| ext.config_script = "extconf.rb" | ||
| end | ||
|
|
||
| Rake::TestTask.new(:test => :build) do |t| | ||
| t.test_files = FileList["tests/*.rb"] | ||
| end | ||
|
|
||
| task :chmod do | ||
| File.chmod(0755, "lib/protobuf_c.so") | ||
| end | ||
|
|
||
| Gem::PackageTask.new(spec) do |pkg| | ||
| end | ||
| task :package => :chmod | ||
| task :gem => :chmod | ||
|
|
||
| task :build => [:clean, :compile] | ||
| task :default => [:build] | ||
|
|
||
| # vim:sw=2:et | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name collides with already existing and maintained since 2011 project - https://github.com/localshred/protobuf. Can we change it to
google-protobuffor example and host on rubygems.org?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads-up. I think Chris will follow up with a PR to rename this to something that doesn't collide with pre-existing work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, PR coming for this.