Fix mixing rules from builtins and protobuf#18435
Merged
copybara-service[bot] merged 1 commit intomainfrom Sep 24, 2024
Merged
Conversation
copybara-service
bot
force-pushed
the
test_676608530
branch
4 times, most recently
from
0e322c2 to
3e2aa97
Compare
The rules in protobuf and built-in Bazel don't mix well. Different aspects may cause actions conflicts. The safest way is to use built-in rules whenever they are still present. proto_library should be safe, because it's not using an aspect. py_proto_library never had a built-in implementation, so it's also safe. This still makes it possible to use the rules on Bazel 7, but only with --incompatible_autoload_externally enabled. PiperOrigin-RevId: 678446311
copybara-service
bot
force-pushed
the
test_676608530
branch
from
3e2aa97 to
cb1f518
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix mixing rules from builtins and protobuf
The rules in protobuf and built-in Bazel don't mix well. Different aspects may cause actions conflicts. The safest way is to use built-in rules whenever they are still present.
proto_library should be safe, because it's not using an aspect. py_proto_library never had a built-in implementation, so it's also safe.
This still makes it possible to use the rules on Bazel 7, but only with --incompatible_autoload_externally enabled.