[ObjC] Don't use unions and instead use memcpy for the type swaps. #6672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasvl
changed the title
thomasvl
force-pushed
the
aligns
branch
2 times, most recently
from
3fdfbc4 to
602622b
Compare
thomasvl
changed the title
dmaclach
approved these changes
Sep 19, 2019
Contributor
|
This still crashes |
Contributor
Author
|
@paulb777 which Xcode version(s) and can you share your repo I can poke at it more directly? |
The code in question hasn't change in a long time so the cause of firebase/firebase-ios-sdk#3851 still appears to be an Xcode 11 clang change/bug; but this does appear to be slightly better code for the work being done.
thomasvl
added a commit
to thomasvl/protobuf
that referenced
this pull request
Sep 20, 2019
…rotocolbuffers#6672) The code in question hasn't change in a long time so the cause of firebase/firebase-ios-sdk#3851 still appears to be an Xcode 11 clang change/bug; but this does appear to be slightly better code for the work being done. Cleanup along the way for protocolbuffers#6679
thomasvl
added a commit
to thomasvl/protobuf
that referenced
this pull request
Sep 20, 2019
…rotocolbuffers#6672) The code in question hasn't change in a long time so the cause of firebase/firebase-ios-sdk#3851 still appears to be an Xcode 11 clang change/bug; but this does appear to be slightly better code for the work being done. Cleanup along the way for protocolbuffers#6679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in question hasn't change in a long time so there likely is a compiler
change that is causing this to suddenly be an issue. memcpy should be a better
code pattern in general.
Should address firebase/firebase-ios-sdk#3851