Use uninitialized array allocation #7857
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JVM has the optimization for eliminating zeroing when the allocation is followed by
System.arraycopy. For codepaths that usesUnsafeUtil.copyMemorythe allocation is allocated and the zeroing takes a fair amount of CPU cycles when array size is large.Java 9+ has
jdk.internal.misc.Unsafe.allocateUninitializedArraywhich does what we want.Related to gRPC's optimization for passing
Iterable<ByteBuffer>into Protobuf.I've run the gRPC transport benchmark with 1 thread and 2MB response messages on Java 11:
(The full benchmark results are here and here. The baseline commit is 70b0286)
We can see this change gives about 9.6% performance improvement for gRPC running on Java 11.