Skip to content

Allow $ in casing-related rules #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ernestognw wants to merge 3 commits into from
Closed

Allow $ in casing-related rules #453

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a10a5e
Allow use of variables starting with `$` in `var-name-mixedcase`
ernestognw Jul 14, 2023
3922c78
Complete $ support for every identifier naming
ernestognw Jul 19, 2023
d1da074
Merge branch 'develop' into chore/support-$-in-var-name-mixedcase
dbale-altoros Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Allow use of variables starting with $ in var-name-mixedcase
  • Loading branch information
@ernestognw
ernestognw committed Jul 14, 2023
commit 3a10a5ec427549947b43324ed75e40ce1dfe096c
2 changes: 1 addition & 1 deletion lib/common/identifier-naming.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ function match(text, regex) {

module.exports = {
isMixedCase(text) {
return match(text, /[_]*[a-z]+[a-zA-Z0-9$]*[_]?/)
return match(text, /[_]*[a-z$]+[a-zA-Z0-9$]*[_]?/)
},

isNotMixedCase(text) {
Expand Down
17 changes: 17 additions & 0 deletions test/rules/naming/var-name-mixedcase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,21 @@ describe('Linter - var-name-mixedcase', () => {

assert.equal(report.errorCount, 0)
})

const WITH_$ = {
$: contractWith('uint32 private $ = 10;'),
'starting with $': contractWith('uint32 private $D = 10;'),
'containing a $': contractWith('uint32 private testWith$Contained = 10;'),
'ending with $': contractWith('uint32 private testWithEnding$ = 10;'),
}

for (const [key, code] of Object.entries(WITH_$)) {
it(`should not raise var name error for variables ${key}`, () => {
const report = linter.processStr(code, {
rules: { 'no-unused-vars': 'error', 'var-name-mixedcase': 'error' },
})

assert.equal(report.errorCount, 0)
})
}
})