Skip to content
This repository was archived by the owner on Jun 27, 2024. It is now read-only.

use get instead of replace inertia method #23

Merged
merged 4 commits into from
May 30, 2021
Merged

use get instead of replace inertia method #23

merged 4 commits into from
May 30, 2021

Conversation

@donmbelembe
Copy link
Contributor

@donmbelembe donmbelembe commented May 20, 2021

fixes #9

@pascalbaljet
Copy link
Contributor

pascalbaljet commented May 24, 2021

Thanks for this! In addition to the preserveState option, shouldn't the replace option be added as well?

https://github.com/inertiajs/inertia/blob/master/packages/inertia/src/router.ts#L447

@donmbelembe
Copy link
Contributor Author

donmbelembe commented May 25, 2021

You're right, fixed

@pascalbaljet pascalbaljet merged commit 03abcc8 into protonemedia:main May 30, 2021
@pascalbaljet
Copy link
Contributor

pascalbaljet commented May 30, 2021

Thanks, it's merged in v1.3.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inertia.replace is deprecated

2 participants

@donmbelembe @pascalbaljet