Chore: Remove the initEngine methods, and update Warm test. #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rachel Green <[email protected]>
rachgreen33
requested review from
PiotrSikora,
martijneken,
mpwarres and
leonm1
as code owners
PiotrSikora
reviewed
Sep 19, 2025
| // We skip NullVM because warm() is a noop, and we skip wasmedge because its engine is initialized | ||
| // in the constructor vs. on cold start. | ||
| if (engine_ == "null" || engine_ == "wasmedge") { | ||
| std::cout << "Skipping warm() performance assertions for NullVm." << std::endl; |
There was a problem hiding this comment.
Nit: This error doesn't mention WasmEdge. Either include the engine_ in the output or split it into two ifs.
Comment on lines
+58
to
+59
| // We skip NullVM because warm() is a noop, and we skip wasmedge because its engine is initialized | ||
| // in the constructor vs. on cold start. |
There was a problem hiding this comment.
Maybe try moving things inside WasmEdge implementation to keep warming-up consistent across all engines, or error out in warm() to signal that it doesn't work.
Alternatively, as discussed in on of the meetings, it's worth considering whether we want to keep WasmEdge at all, since it hasn't been updated in a while, and I'm not aware of anyone using it. cc @mpwarres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init*Engine methods are not necessary, because warm() itself initializes the engines.
This is a follow-up to #447, which added Init*Engine along with warm functionality.