feat: allow ip prefix in x-ports#358
Open
miekg wants to merge 14 commits into
Open
Conversation
This allows you to specify a, portable but global compose that binds only to certain interfaces. Namely those that are contained in the prefix spec. This should a better idea than psviderski#333 Signed-off-by: Miek Gieben <miek@miek.nl>
This was referenced May 6, 2026
Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: Miek Gieben <miek@miek.nl>
Contributor
Author
|
finally came around to actually deploy this, with the fixed I pushed: with x-ports:
- 80:80@host
- 443:443@host
- 443:443/udp@host
- 131.174.88.0/24:53:53/tcp@host
- 131.174.88.0/24:53:53/udp@host |
Signed-off-by: Miek Gieben <miek@miek.nl>
psviderski
reviewed
May 12, 2026
Owner
psviderski
left a comment
There was a problem hiding this comment.
Overall looks good but please see a comment about another unhandled case when splitting by slashes. We might want to rework the entire logic to start splitting by colons first.
Co-authored-by: Pasha Sviderski <me@psviderski.name>
Co-authored-by: Pasha Sviderski <me@psviderski.name>
Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: Miek Gieben <miek@miek.nl>
Added this back, makes diff smaller Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: Miek Gieben <miek@miek.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows you to specify a, portable but global compose that binds only to certain interfaces. Namely those that are contained in the prefix spec.
This should a better idea than #333