Skip to content

feat: upgrade React to v16.6.3 #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleclarson wants to merge 13 commits into
base: master
Choose a base branch
from
Open

feat: upgrade React to v16.6.3 #225

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a452209
feat: upgrade React to v16.6.3
aleclarson Jan 29, 2019
c3a959d
Log query name for fetchRelayQuery
alexeylang Jan 11, 2018
7d2f74b
RN: Remove React Stack Systrace Logic
yungsters Feb 20, 2018
a24dedb
Move TouchHistoryMath from React Repo to React Native
sebmarkbage Apr 6, 2018
d14d4a7
Move takeSnapshot from React repo to RN
sebmarkbage Apr 8, 2018
9246b13
fix: delete ReactNativePropRegistry
aleclarson Jan 28, 2019
a9c2266
fix: stop using ReactNativeComponentTree
aleclarson Jan 28, 2019
d2ad9c7
fix: stop using ReactNativeBridgeEventPlugin
aleclarson Jan 28, 2019
11144a8
throw when <View> exists in <Text>
aleclarson Jan 28, 2019
b412767
fix: remove unused Renderer shims
aleclarson Jan 28, 2019
9c0e377
fix: add @providesModule to updated Renderer shims
aleclarson Jan 28, 2019
d40506d
React sync for revisions 6bf5e85...aa94237
aleclarson Mar 14, 2019
a8e563b
fix: add @providesModule to Renderer shims
aleclarson Mar 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: stop using ReactNativeComponentTree 
Copied from: facebook/react-native@a275eac
  • Loading branch information
@aleclarson
aleclarson committed Jan 29, 2019
commit a9c22664adf37e962f5aa884185e46b405c66886
15 changes: 1 addition & 14 deletions Libraries/Components/ScrollResponder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const performanceNow = require('fbjs/lib/performanceNow');
const warning = require('fbjs/lib/warning');

const { ScrollViewManager } = require('NativeModules');
const { getInstanceFromNode } = require('ReactNativeComponentTree');

/**
* Mixin that can be integrated in order to handle scrolling that plays well
Expand Down Expand Up @@ -117,15 +116,6 @@ type State = {
};
type Event = Object;

function isTagInstanceOfTextInput(tag) {
const instance = getInstanceFromNode(tag);
return instance && instance.viewConfig && (
instance.viewConfig.uiViewClassName === 'AndroidTextInput' ||
instance.viewConfig.uiViewClassName === 'RCTMultilineTextInputView' ||
instance.viewConfig.uiViewClassName === 'RCTSinglelineTextInputView'
);
}

const ScrollResponderMixin = {
mixins: [Subscribable.Mixin],
scrollResponderMixinGetInitialState: function(): State {
Expand Down Expand Up @@ -208,10 +198,7 @@ const ScrollResponderMixin = {
const {keyboardShouldPersistTaps} = this.props;
const keyboardNeverPersistTaps = !keyboardShouldPersistTaps ||
keyboardShouldPersistTaps === 'never';
if (keyboardNeverPersistTaps &&
currentlyFocusedTextInput != null &&
!isTagInstanceOfTextInput(e.target)
) {
if (keyboardNeverPersistTaps && currentlyFocusedTextInput != null) {
return true;
}
return this.scrollResponderIsAnimating();
Expand Down