Adds tabBarPosition 'overlayTop', 'overlayBottom' with docs, example #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks good 👍 I will try then merge. |
skv-headless
added a commit
that referenced
this pull request
Feb 20, 2016
Adds tabBarPosition 'overlayTop', 'overlayBottom' with docs, example
Contributor
Author
|
Awesome, thanks Evgeniy! |
Collaborator
|
@mosesoak thank you. I like this feature very much 👍 |
caglaruba
pushed a commit
to caglaruba/react-native-scrollable-tab-view
that referenced
this pull request
Aug 22, 2019
Adds tabBarPosition 'overlayTop', 'overlayBottom' with docs, example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed update to #150 incorporating suggestions from @skv-headless.
README update:
tabBarPosition(String) Defaults to"top"."bottom"to position the tab bar below content."overlayTop"or"overlayBottom"for a semitransparent tab bar that overlays content. Custom tab bars must consume a style prop on their outer element to support this feature:style={this.props.style}.To see it in action uncomment the
OverlayExample, which uses vector icons for page content:Additional visual example of how this might look in an app (I didn't include this anywhere in the commit but you can feel free to use it if you want):