Skip to content

Fix mismatch in id_queue triggering obscure errors in QuestaSim #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niwis merged 2 commits into from
May 6, 2025
Merged

Fix mismatch in id_queue triggering obscure errors in QuestaSim #254

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9540f88
Fix mismatch in id_queue triggering obscure errors in QuestaSim in so…
FrancescoConti Mar 17, 2025
0d947ea
id_queue: Apply struct access fix module-wide
niwis May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/id_queue.sv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ module id_queue #(
if (oup_pop_i) begin
// Set free bit of linked data entry, all other bits are don't care.
linked_data_d[head_tail_q[match_in_idx].head] = '0;
linked_data_d[head_tail_q[match_in_idx].head][0] = 1'b1;
linked_data_d[head_tail_q[match_in_idx].head].free = 1'b1;
if (head_tail_q[match_in_idx].head == head_tail_q[match_in_idx].tail) begin
head_tail_d[match_in_idx] = '{free: 1'b1, default: '0};
end else begin
Expand All @@ -261,7 +261,7 @@ module id_queue #(
oup_data_popped = 1'b1;
// Set free bit of linked data entry, all other bits are don't care.
linked_data_d[head_tail_q[match_out_idx].head] = '0;
linked_data_d[head_tail_q[match_out_idx].head][0] = 1'b1;
linked_data_d[head_tail_q[match_out_idx].head].free = 1'b1;
if (head_tail_q[match_out_idx].head
== head_tail_q[match_out_idx].tail) begin
oup_ht_popped = 1'b1;
Expand Down Expand Up @@ -403,8 +403,8 @@ module id_queue #(
always_ff @(posedge clk_i, negedge rst_ni) begin
if (!rst_ni) begin
// Set free bit of linked data entries, all other bits are don't care.
linked_data_q[i] <= '0;
linked_data_q[i][0] <= 1'b1;
linked_data_q[i] <= '0;
linked_data_q[i].free <= 1'b1;
end else begin
linked_data_q[i] <= linked_data_d[i];
end
Expand Down