Unbreak Debian support with custom encoding #1564
postgresql_psql autorequire
It does not really make sense to require the "begin" anchor, the `postgresql_psql` type communicating with the server, it makes more sense to require the "end" anchor which mean that the server is running and reachable.
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -135,7 +135,7 @@ def matches(value) | |
| end | ||
|
|
||
| autorequire(:anchor) do | ||
| ["postgresql::server::service::end::#{self[:instance]}"] | ||
| end | ||
|
|
||
| autorequire(:service) do | ||
|
Collaborator
There was a problem hiding this comment. I'm trying to understand the logic. Don't you always need the server to be running to execute any SQL statements?
Collaborator
There was a problem hiding this comment. yes, but the service doesn't seem to be available immediately after start. There's a custom resource that waits until the tcp port is open and I think we should depend on that.
Collaborator
There was a problem hiding this comment. Oh yes, that makes sense. Though with the newest versions (Fedora 38 with PostgreSQL 15) I see the systemd unit is Digging into this, it was introduced in postgres/postgres@7d17e68 so with PostgreSQL 9.6 it became possible to support. Looking at EL8 that's built with
Contributor
There was a problem hiding this comment.
These seem to be the relevant bugs about this: |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as an alternative, can we maybe autorequire the postgresql_conn_validator resource?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That quite make sense. I'll dig into this.