Skip to content

Avoid opening the file in postgresql_conf #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Avoid opening the file in postgresql_conf #1599

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a5ad40
Fix spelling of PostgreSQL in a debug statement
ekohl May 30, 2024
9c5e5ce
Avoid opening the file in postgresql_conf
ekohl May 30, 2024
f2b193d
Pass an offset to with_index to calculate line numbers
ekohl May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Pass an offset to with_index to calculate line numbers 
Rather than starting from 0 and always adding 1, this tells with_index
to start at 1.
  • Loading branch information
@ekohl @bastelfreak
ekohl authored and bastelfreak committed Jul 12, 2024
commit f2b193dd6ff7a0e0375a3ffaa610cd0727620219
3 changes: 1 addition & 2 deletions lib/puppet/provider/postgresql_conf/ruby.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ def parse_config
active_settings = []
# iterate the file and construct a hash for every matching/active setting
# the hash is pushed to the array and the array is returned
File.foreach(resource[:target]).with_index do |line, index|
line_number = index + 1
File.foreach(resource[:target]).with_index(1) do |line, line_number|
matches = line.match(active_values_regex)
if matches
value = if matches[:value].to_i.to_s == matches[:value]
Expand Down