$password_hash not being encrypted when sent to postgresql::database_user #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom a plain text password
|
Can one of the admins verify this patch? |
|
I have exactly the same issue on my server. The alter role get executed every time. Verified, this PR fixed the issue. Thanks! |
Contributor
|
Fixed with #225. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216 where $password_hash was not being encrypted which caused an ALTER ROLE to be run every time the puppet agent runs. Also Fixes puppetlabs/puppetlabs-puppetdb#72 downstream.
Because of this fix, the postgresql::db::password parameter MUST be passed in plain text. This may be undesirable for some/most. Perhaps there should be an option to either send the password as a hash as well as plain text, OR change the postgresql::db::password to postgresql::db::password_hash and require it to be sent as a hash.