Skip to content

Add postgresql::server::extension definition #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2015
Merged

Add postgresql::server::extension definition #521

merged 1 commit into from
Feb 4, 2015

Conversation

@raphink
Copy link
Contributor

@raphink raphink commented Nov 4, 2014

This PR adds a postgresql::server::extension definition used to activate an extension on a given database.

@raphink raphink mentioned this pull request Nov 4, 2014
Closed
@igalic
Copy link
Contributor

igalic commented Nov 7, 2014

i'd pass two optional parameters:

package_name, package_ensure - to install those extensions from a package, if necessary.

otherwise, 👍

@raphink
Copy link
Contributor Author

raphink commented Nov 19, 2014

@igalic In that case, I guess https://github.com/puppetlabs/puppetlabs-postgresql/blob/master/manifests/server/postgis.pp would be refactored so postgresql::server::extension installs the package instead of postgresql::server::postgis?

@raphink
Copy link
Contributor Author

raphink commented Nov 19, 2014

As in #522

@igalic
Copy link
Contributor

igalic commented Nov 19, 2014

+1

1 similar comment
@mcanevet
Copy link
Contributor

mcanevet commented Dec 5, 2014

+1

@raphink
Copy link
Contributor Author

raphink commented Dec 5, 2014

@igalic how about that?

@igalic
Copy link
Contributor

igalic commented Dec 5, 2014

looks good to me.!
please squash (at least) that test-failing-commit.

@raphink
Copy link
Contributor Author

raphink commented Dec 5, 2014

Squashed.

@igalic
Copy link
Contributor

igalic commented Dec 6, 2014

@cmurphy: ping

@cmurphy
Copy link
Contributor

cmurphy commented Dec 8, 2014

Could you add docs to the README?

@raphink
Copy link
Contributor Author

raphink commented Dec 8, 2014

@cmurphy Done.

cmurphy
cmurphy reviewed Dec 8, 2014
View reviewed changes
README.md Outdated
Copy link
Contributor

@cmurphy cmurphy Dec 8, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a define and not a class, to be consistent this should be changed to Resource: and moved to be with the other resources

@raphink
Copy link
Contributor Author

raphink commented Dec 8, 2014

Sorry for that, just fixed it @cmurphy

@igalic
Copy link
Contributor

igalic commented Dec 9, 2014

travis' failures can mostly be ignored…

@raphink
Copy link
Contributor Author

raphink commented Dec 9, 2014

Yes indeed…

cmurphy added a commit that referenced this pull request Feb 4, 2015
@cmurphy
Merge pull request #521 from raphink/dev/server_extension
d42b821 
Add postgresql::server::extension definition
@cmurphy cmurphy merged commit d42b821 into puppetlabs:master Feb 4, 2015
cegeka-jenkins pushed a commit to cegeka/puppet-postgresql that referenced this pull request Oct 23, 2017
@cmurphy
Merge pull request puppetlabs#521 from raphink/dev/server_extension
5402b83 
Add postgresql::server::extension definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@raphink @igalic @mcanevet @cmurphy @Ramesh7