add a $pg_hba_conf_template parameter to the class postgresql::config to... #96
Conversation
… to allow the default pg_hba.conf template to be overrideen
example usage:
class { 'postgresql::server':
config_hash => {
'pg_hba_conf_template' => 'mymodule/pg_hba.conf.erb',
},
}
ghost
assigned
|
#120 definitely lessons the motivation for this pull request but some |
|
@jhoblitt do you think in this case a template is what you are after as an escape hatch? Or just a file resource with your static settings baked within it? My point being mainly around the fact that the template is obviously built around fairly specific input data. The template today obviously had bugs due to lack of full functionality that you were trying to get around right? After #120 do you still feel like a templated escape hatch is required? What kind of thing would you want if #120 became a reality and why? In the case of the new postgresql::pg_hba_rule it is made up of a template for each ruleset - not a complete template btw. so it changes the landscape a little. |
|
@kbarber I don't see the need for an escape hatch at this point as #120 looks great. However, I've found it useful when converting from an existing unmanaged config to start out by just supplying the old conf file as a template without any ERB markup (I do this with apache all the time) so it's one less thing to debug. As an analogy, I don't ever get on a ship expecting it to sink but I still want to make sure it has enough life boats. :) |
2 participants
... allow the default pg_hba.conf template to be overrideen
example usage:
class { 'postgresql::server':
config_hash => {
'pg_hba_conf_template' => 'mymodule/pg_hba.conf.erb',
},
}
Per discussion in #72