Skip to content

Improve parseyaml function #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitryilyin wants to merge 1 commit into from
Closed

Improve parseyaml function #509

dmitryilyin wants to merge 1 commit into from

Conversation

@dmitryilyin
Copy link

@dmitryilyin dmitryilyin commented Aug 24, 2015

  • Add default value support
  • Update tests

DavidS
DavidS reviewed Aug 24, 2015
View reviewed changes
lib/puppet/parser/functions/parseyaml.rb
Copy link
Contributor

@DavidS DavidS Aug 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L17-19 could just be YAML::load(arguments[0]) || arguments[1] .

Copy link

@holser holser Aug 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@DavidS
Copy link
Contributor

DavidS commented Aug 24, 2015

Nice idea and good call on those additional specs :-) I've added a small comment on the style of the actual function body. The changes from the doc string need to be repeated in the README.

The main question though is why parseyaml needs a separate default value implementation when there is pick and pick_default ?

[MODULES-2462] Improve parseyaml function
8f0eff0 
* Add default value support
  Second argument will be returned if yaml cannot be parsed
  instead of false value
* Update tests
@DavidS DavidS mentioned this pull request Aug 24, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dmitryilyin @DavidS @holser