Skip to content

Skip non-existing paths in $MODULEPATH silently #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Skip non-existing paths in $MODULEPATH silently #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Skip non-existing paths in $MODULEPATH silently 
In `map`, a `next` will leave a `nil` value in the array.  This is a
problem since `FileTest.directory? nil` raises "TypeError: no implicit
conversion of nil into String"

Bug was introduced in v4.0.1, in commit b6bfd6f
  • Loading branch information
@kjetilho
kjetilho committed Dec 10, 2023
commit c3c8171840bd71557450761bb1842f3a485aa6ca
2 changes: 1 addition & 1 deletion lib/puppetlabs_spec_helper/module_spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def verify_contents(subject, title, expected_lines)

Dir.entries(dir).grep_v(/^\./).map { |f| File.join(dir, f, 'spec', 'lib') }
end
components.flatten.each do |d|
components.compact.flatten.each do |d|
$LOAD_PATH << d if FileTest.directory?(d) && !$LOAD_PATH.include?(d)
end

Expand Down