Skip to content

(breaking) - Remove build rake tasks #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2024
Merged

(breaking) - Remove build rake tasks #472

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aed2aa3
(breaking) - Remove build rake tasks
Sep 11, 2024
f9878f8
(CAT-2056) - Remove 'rake clean' task
Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
(breaking) - Remove build rake tasks 
This commit removes the build rake tasks from puppetlabs_spec_helper, as
it does not make sense to have these exist in a gem which sole purpose
is to help unit testing.
  • Loading branch information
jordanbreen28 committed Sep 17, 2024
commit aed2aa374c4f8885ad0c02149cec97d7c1bcb279
24 changes: 0 additions & 24 deletions lib/puppetlabs_spec_helper/rake_tasks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,30 +121,6 @@
end
end

desc 'Build puppet module package'
task :build do
Rake::Task['build:pdk'].invoke
end

namespace :build do
desc 'Build Puppet module with PDK'
task :pdk do
require 'pdk/util'
require 'pdk/module/build'

path = PDK::Module::Build.invoke(force: true, 'target-dir': File.join(Dir.pwd, 'pkg'))
puts "Module built: #{path}"
rescue LoadError
_ = `pdk --version`
unless $CHILD_STATUS.success?
warn 'Unable to build module. Please install PDK or add the `pdk` gem to your Gemfile.'
abort
end

system('pdk build --force')
end
end

desc 'Clean a built module package'
task :clean do
FileUtils.rm_rf('pkg/')
Expand Down