ParAff applicative should abort on uncaught exception #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@natefaubion Thanks, will review this today! |
jdegoes
reviewed
Dec 19, 2017
| r2 ← joinFiber f1 | ||
| pure (r1 == "foobar" && r2.a == "foo" && r2.b == "bar") | ||
|
|
||
| test_parallel_throw ∷ ∀ eff. TestAff eff Unit |
There was a problem hiding this comment.
Worth adding a test here for parallel a / never.
| tmp = true; | ||
| kid = killId++; | ||
|
|
||
| kills[kid] = kill(early, fail === lhs ? head._2 : head._1, function (/* unused */) { |
There was a problem hiding this comment.
This looks tricky. Don't understand the encoding well enough to say if this is correct.
There was a problem hiding this comment.
head= the current Applicative node in the stackhead._1= the left-hand-side nodehead._2= the right-hand-side nodefail= the resolved exceptionlhs= the resolved value of the left-hand-side parallel operation (head._1._3)rhs= the resolved value of the right-hand-side parallel operation (head._2._3)
So, if the left-hand-side resolved to a failure, kill the right-hand-side, otherwise kill the left-hand-side.
There was a problem hiding this comment.
I don't think I actually need rhs anymore, so I can lose that.
There was a problem hiding this comment.
Nevermind, it's used in the success branches.
|
garyb
approved these changes
Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134