Skip to content

MAINT: password param of _security._alg32(...) is only a string, not bytes#1259

Merged
MartinThoma merged 3 commits intomainfrom
tst-remove-unreachable-code
Aug 20, 2022
Merged

MAINT: password param of _security._alg32(...) is only a string, not bytes#1259
MartinThoma merged 3 commits intomainfrom
tst-remove-unreachable-code

Conversation

@MartinThoma
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #1259 (169ad72) into main (c188fb0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1259      +/-   ##
==========================================
+ Coverage   94.81%   94.85%   +0.03%     
==========================================
  Files          30       30              
  Lines        4974     4972       -2     
  Branches     1024     1023       -1     
==========================================
  Hits         4716     4716              
+ Misses        144      143       -1     
+ Partials      114      113       -1     
Impacted Files Coverage Δ
PyPDF2/_security.py 97.46% <100.00%> (+2.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MartinThoma MartinThoma changed the title MAINT: Remove unreachable code MAINT: password param of _security._alg32(...) is only a string, not bytes Aug 20, 2022
@MartinThoma MartinThoma merged commit 7f0a6b0 into main Aug 20, 2022
@MartinThoma MartinThoma deleted the tst-remove-unreachable-code branch August 20, 2022 15:10
MartinThoma added a commit that referenced this pull request Aug 21, 2022
Robustness (ROB):
-  Decrypt returns empty bytestring (#1258)

Documentation (DOC):
-  Adding WevertonGomes as a Contributor

Developer Experience (DEV):
-  Modify CI to better verify built package contents (#1244)

Maintenance (MAINT):
-  Remove unused sign function in _extract_text (#1262)
-  Remove \'mine\' as PdfMerger always creates the stream (#1261)
-  Let PdfMerger._create_stream raise NotImplemented (#1251)
-  password param of _security._alg32(...) is only a string, not bytes (#1259)
-  Remove unreachable code in read_block_backwards (#1250)

Testing (TST):
-  Delete annotations (#1263)
-  Close PdfMerger in tests (#1260)
-  PdfReader.xmp_metadata workflow (#1257)
-  Various PdfWriter (Layout, Bookmark deprecation) (#1249)

Full Changelog: 2.10.2...2.10.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant